flyrain commented on code in PR #7326:
URL: https://github.com/apache/iceberg/pull/7326#discussion_r1164654513
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/ChangelogIterator.java:
##########
@@ -89,15 +91,29 @@ private ChangelogIterator(
* @param rowType the schema of the rows
* @param identifierFields the names of the identifier columns, which
determine if rows are the
* same
+ * @param netChanges whether to compute net changes across all snapshots
* @return a new {@link ChangelogIterator} instance concatenated with the
null-removal iterator
*/
public static Iterator<Row> create(
Review Comment:
Per [Semantic Versioning Guarantees post
1.0](https://www.mail-archive.com/[email protected]/msg03786.html) , we
don't think this is a public API, and don't provide the guarantees of
compatibility. We should be able to change it for this class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
