flyrain commented on code in PR #7326:
URL: https://github.com/apache/iceberg/pull/7326#discussion_r1164686467
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/procedures/CreateChangelogViewProcedure.java:
##########
@@ -101,6 +103,7 @@ public class CreateChangelogViewProcedure extends
BaseProcedure {
COMPUTE_UPDATES_PARAM,
REMOVE_CARRYOVERS_PARAM,
IDENTIFIER_COLUMNS_PARAM,
+ NET_CHANGES,
Review Comment:
Here is a list of options to generate changelog before this PR:
1. Keeping carry-over rows and not computing pre/post images. I double how
useful it is since user can directly use the change table by `select * from
table.changes`
2. Removing carry-over rows, but still no pre/post images. this is the
default behavior.
3. Removing carry-over rows and computing pre/post images.
In this PR, we added the fourth option
4. Removing carry-over rows, computing pre/post images, and removing
intermediate changes across multiple snapshots.
Does that make sense?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
