[GitHub] [iceberg] nastra commented on a diff in pull request #7337: Core: Support loading multiple metrics reporters

Thu, 13 Apr 2023 07:19:30 -0700 


nastra commented on code in PR #7337:
URL: https://github.com/apache/iceberg/pull/7337#discussion_r1165597698


##########
core/src/main/java/org/apache/iceberg/CatalogUtil.java:
##########
@@ -448,4 +475,46 @@ public static MetricsReporter 
loadMetricsReporter(Map<String, String> properties
 
     return reporter;
   }
+
+  static class CompositeMetricsReporter implements MetricsReporter {

Review Comment:
   In fact I just realized that the current implementation of 
`TableScanContext#reportWith()` that uses `Collection<MetricsReporter>` 
actually can contain the same reporter multiple times (which I've seen in some 
tests where the same thing is reported twice to the log file)
   
   
![multiple-logging-reporters](https://user-images.githubusercontent.com/271029/231788204-6aa2418a-1b4e-4ba2-ac81-96ee57a28e9a.png)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to