nastra commented on code in PR #7337:
URL: https://github.com/apache/iceberg/pull/7337#discussion_r1169659304
##########
core/src/main/java/org/apache/iceberg/CatalogUtil.java:
##########
@@ -420,6 +430,23 @@ public static MetricsReporter
loadMetricsReporter(Map<String, String> properties
return LoggingMetricsReporter.instance();
}
+ List<String> reporters = COMMA.splitToList(impl);
+ if (reporters.size() == 1) {
+ return loadSingleMetricsReporter(properties, impl);
+ }
+
+ LOG.info("Loading multiple MetricsReporter implementations: {}", impl);
Review Comment:
there was a slight misunderstanding when @rdblue and I talked offline about
this. We only wanted to introduce a `CompositeMetricsReporter` but didn't want
to load multiple metrics reporters through
`CatalogProperties.METRICS_REPORTER_IMPL`.
Therefore I've reverted changes around `CatalogUtil`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
