rdblue commented on code in PR #7337:
URL: https://github.com/apache/iceberg/pull/7337#discussion_r1171780663
##########
core/src/main/java/org/apache/iceberg/TableScanContext.java:
##########
@@ -353,17 +352,22 @@ TableScanContext planWith(ExecutorService executor) {
toSnapshotId,
executor,
fromSnapshotInclusive,
- metricsReporters);
+ metricsReporter);
}
- Collection<MetricsReporter> metricsReporters() {
- return metricsReporters;
+ MetricsReporter metricsReporter() {
+ return metricsReporter;
}
TableScanContext reportWith(MetricsReporter reporter) {
- ImmutableList.Builder<MetricsReporter> builder = ImmutableList.builder();
- builder.addAll(metricsReporters);
- builder.add(reporter);
+ MetricsReporter configured;
+ if (LoggingMetricsReporter.class.equals(metricsReporter.getClass())) {
+ // we're overriding the default LoggingMetricsReporter
Review Comment:
Avoid the use of personal pronouns in comments and documentation. Using "we"
or "I" draws unnecessary attention to a subject that doesn't need to be there
and makes documentation less direct. Instead, this could be "override the
default logging reporter".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
