rdblue commented on code in PR #7337:
URL: https://github.com/apache/iceberg/pull/7337#discussion_r1171782020
##########
core/src/main/java/org/apache/iceberg/TableScanContext.java:
##########
@@ -353,17 +352,22 @@ TableScanContext planWith(ExecutorService executor) {
toSnapshotId,
executor,
fromSnapshotInclusive,
- metricsReporters);
+ metricsReporter);
}
- Collection<MetricsReporter> metricsReporters() {
- return metricsReporters;
+ MetricsReporter metricsReporter() {
+ return metricsReporter;
Review Comment:
Rather than having a default that requires awkward logic in `reportWith`,
why not set the default to `null` and return
`LoggingMetricsReporter.instance()` here if the reporter is null? That seems
easier to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
