szehon-ho commented on code in PR #7389:
URL: https://github.com/apache/iceberg/pull/7389#discussion_r1173413407
##########
core/src/main/java/org/apache/iceberg/actions/SizeBasedFileRewriter.java:
##########
@@ -178,6 +180,16 @@ protected long inputSize(List<T> group) {
return group.stream().mapToLong(ContentScanTask::length).sum();
}
+ /**
+ * Returns the smallest of our max write file threshold and our estimated
split size based on the
+ * number of output files we want to generate. Add an overhead onto the
estimated split size to
+ * try to avoid small errors in size creating brand-new files.
+ */
+ protected long splitSize(long inputSize) {
Review Comment:
Moved from SparkBinPackDataRewriter to re-use
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
