aokolnychyi commented on code in PR #7389:
URL: https://github.com/apache/iceberg/pull/7389#discussion_r1179615134
##########
api/src/main/java/org/apache/iceberg/RewriteFiles.java:
##########
@@ -57,6 +57,16 @@ default RewriteFiles rewriteFiles(Set<DataFile>
filesToDelete, Set<DataFile> fil
RewriteFiles rewriteFiles(
Set<DataFile> filesToDelete, Set<DataFile> filesToAdd, long
sequenceNumber);
+ /**
+ * Add a rewrite that replaces one set of delete files with another set that
contains the same
+ * data.
+ *
+ * @param filesToDelete files that will be replaced (deleted), cannot be
null or empty.
+ * @param filesToAdd files that will be added, cannot be null or empty.
+ * @return this for method chaining
+ */
+ RewriteFiles rewriteDeleteFiles(Set<DeleteFile> filesToDelete,
Set<DeleteFile> filesToAdd);
Review Comment:
Let's not add an overloaded method here. We will rework this API shortly
after. For now, let's use the method that accepts 4 sets. This PR should use
`RewriteFiles` as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
