aokolnychyi commented on code in PR #7389:
URL: https://github.com/apache/iceberg/pull/7389#discussion_r1179627952
##########
api/src/main/java/org/apache/iceberg/actions/RewritePositionDeleteFiles.java:
##########
@@ -41,11 +119,60 @@
RewritePositionDeleteFiles filter(Expression expression);
/** The action result that contains a summary of the execution. */
+ @Value.Immutable
interface Result {
+ List<PositionDeleteGroupRewriteResult> rewriteResults();
+
/** Returns the count of the position deletes that been rewritten. */
int rewrittenDeleteFilesCount();
/** Returns the count of the added delete files. */
int addedDeleteFilesCount();
+
+ /** Returns the number of bytes of position deletes that have been
rewritten */
+ long rewrittenBytesCount();
+
+ /** Returns the number of bytes of newly added position deletes */
+ long addedBytesCount();
+ }
+
+ /**
+ * For a particular position delete file group, the number of position
delete files which are
+ * newly created and the number of files which were formerly part of the
table but have been
+ * rewritten.
+ */
+ @Value.Immutable
+ interface PositionDeleteGroupRewriteResult {
Review Comment:
Since it is a nested class, what about simply `FileGroupRewriteResult` and
`FileGroupInfo`? We usually rarely add any context in the name for nested
classes. Not a strong opinion, though. Would love to hear more from others.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
