wmoustafa commented on PR #7416: URL: https://github.com/apache/iceberg/pull/7416#issuecomment-1528062675
I think it would be great to clarify a few things: 1- If we should document that version summary, namely `engine` and `engine version`, should have a correlation with the view `dialect`. For example, views created from Trino will typically be in Trino SQL. 2- If we should document whether a view version is immutable in terms of adding representations. Can an old (or committed) view version be changed to receive a new representation? 3- If we should document whether a view version can contain two definitions under the same type/dialect. 4- We discussed documenting possible values in the [view interfaces PR](https://github.com/apache/iceberg/pull/4925). For example, similar to what we say that `type` must be `sql`, how about saying that `dialect` could be one of some options? This is just to avoid situations where there are dialects like `spark`, `Spark`, `SparkSQL`, `spark3.3`. Happy to raise an issue or a community discussion around some of the above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
