rdblue commented on PR #7416: URL: https://github.com/apache/iceberg/pull/7416#issuecomment-1531668496
Thanks for reviewing this, @wmoustafa. 1. I'm okay with this, but I don't think it is necessarily the case. Engines could support multiple dialects. Plus, I think it's pretty obvious that it will generally be true. 2. View versions are immutable once created. 3. Right now, there should not be duplicates for any representation type. 4. I'm okay doing this, but it doesn't seem worthwhile to me. There will typically be one implementation per engine and people aren't going to change this often. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
