Fokko commented on code in PR #7472:
URL: https://github.com/apache/iceberg/pull/7472#discussion_r1181246500
##########
python/pyiceberg/schema.py:
##########
@@ -714,7 +714,7 @@ def visit(obj: Union[Schema, IcebergType], visitor:
SchemaVisitor[T]) -> T:
The function traverses the schema in post-order fashion
Args:
- obj(Schema | IcebergType): An instance of a Schema or an IcebergType
+ obj (Schema | IcebergType): An instance of a Schema or an IcebergType
Review Comment:
Should we use the `Union` notation here as well?
##########
python/pyiceberg/transforms.py:
##########
@@ -709,8 +709,11 @@ def _(_type: IcebergType, value: int) -> str:
class UnknownTransform(Transform[S, T]):
"""A transform that represents when an unknown transform is provided
Args:
- source_type (IcebergType): An Iceberg `Type`
transform (str): A string name of a transform
+
+ Keyword Args:
+ source_type (IcebergType): An Iceberg `Type`
Review Comment:
I think it is better to just drop this one. An `UnknownTransform` doesn't
really has a `source_type` since it is just a fallback transform in case we get
an unexpected transform.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
