Fokko commented on code in PR #7472:
URL: https://github.com/apache/iceberg/pull/7472#discussion_r1181259606
##########
python/pyiceberg/schema.py:
##########
@@ -783,7 +783,7 @@ def pre_order_visit(obj: Union[Schema, IcebergType],
visitor: PreOrderSchemaVisi
because we don't use the pre-order traversal much.
Args:
- obj(Schema | IcebergType): An instance of a Schema or an IcebergType
+ obj (Schema | IcebergType): An instance of a Schema or an IcebergType
Review Comment:
```suggestion
obj (Schema, IcebergType): An instance of a Schema or an IcebergType
```
##########
python/pyiceberg/schema.py:
##########
@@ -714,7 +714,7 @@ def visit(obj: Union[Schema, IcebergType], visitor:
SchemaVisitor[T]) -> T:
The function traverses the schema in post-order fashion
Args:
- obj(Schema | IcebergType): An instance of a Schema or an IcebergType
+ obj (Union[Schema | IcebergType]): An instance of a Schema or an
IcebergType
Review Comment:
```suggestion
obj (Union[Schema, IcebergType]): An instance of a Schema or an
IcebergType
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
