nastra commented on code in PR #7336:
URL: https://github.com/apache/iceberg/pull/7336#discussion_r1182460271


##########
api/src/main/java/org/apache/iceberg/catalog/Catalog.java:
##########
@@ -46,7 +46,8 @@ default String name() {
    *
    * @param namespace a namespace
    * @return a list of identifiers for tables
-   * @throws NotFoundException if the namespace is not found
+   * @throws NoSuchNamespaceException if the namespace is not found
+   * @throws IllegalArgumentException if the namespace is invalid for the 
catalog

Review Comment:
   thinking more about this, I would probably remove `@throws 
IllegalArgumentException` and just have the change from `NotFoundException` to 
`NoSuchNamespaceException`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to