nastra commented on code in PR #7336:
URL: https://github.com/apache/iceberg/pull/7336#discussion_r1182565500
##########
api/src/main/java/org/apache/iceberg/catalog/Catalog.java:
##########
@@ -46,7 +46,8 @@ default String name() {
*
* @param namespace a namespace
* @return a list of identifiers for tables
- * @throws NotFoundException if the namespace is not found
+ * @throws NoSuchNamespaceException if the namespace is not found
+ * @throws IllegalArgumentException if the namespace is invalid for the
catalog
Review Comment:
`GlueCatalog` can throw a `ValidationException` (if validation is enabled)
on an invalid namespace, meaning that the implementation details derive from
the Javadoc that is being introduced here.
That's why I think it's probably better to not mention throwing
`IllegalArgumentException` here because implementations aren't consistent with
this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
