RussellSpitzer commented on code in PR #7501:
URL: https://github.com/apache/iceberg/pull/7501#discussion_r1183078559
##########
api/src/main/java/org/apache/iceberg/RewriteFiles.java:
##########
@@ -34,13 +34,57 @@
* will throw a {@link ValidationException}.
*/
public interface RewriteFiles extends SnapshotUpdate<RewriteFiles> {
+ /**
+ * Delete a data file whose content was rewritten.
Review Comment:
Our terminology always throw me a bit off here. We struggle with "delete" =
physically remove and "delete" mark as logically removed. Both are used in
various places and sometimes we also use "remove".
Here I think "originalFile" maybe is more of the logical description,
"original" => "rewritten" instead of "add" and "delete" which are really the
implementation details.
That said i'm fine with just "add" and "delete" since we use them in many
other places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
