aokolnychyi commented on code in PR #7501:
URL: https://github.com/apache/iceberg/pull/7501#discussion_r1183809676
##########
core/src/main/java/org/apache/iceberg/BaseRewriteFiles.java:
##########
@@ -26,6 +26,9 @@
class BaseRewriteFiles extends MergingSnapshotProducer<RewriteFiles>
implements RewriteFiles {
private final Set<DataFile> replacedDataFiles = Sets.newHashSet();
private Long startingSnapshotId = null;
+ private boolean replacesDeleteFiles = false;
Review Comment:
Do you mean checking the underlying `ManifestFilterManager`,
`List<DataFile>` and the map of delete files? I thought about this but was
initially reluctant to touch `ManifestFilterManager` (4 different ways to
delete files).
That said, these boolean flags are a bit odd. Now I am thinking it makes
sense to spend a bit more time and check the underlying structures.
@RussellSpitzer, is this what you meant?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
