rdblue commented on code in PR #7487:
URL: https://github.com/apache/iceberg/pull/7487#discussion_r1183879345
##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -319,6 +329,7 @@ public Table loadTable(SessionContext context,
TableIdentifier identifier) {
}
}
+ final TableIdentifier finalIdentifier = loadedIdent;
Review Comment:
Only instance fields should use `final` in Iceberg. This doesn't actually
help the compiler do smarter things because it can be detected automatically
these days (also, it isn't part of byte code). Since it doesn't help, we omit
it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
