rdblue commented on code in PR #7487:
URL: https://github.com/apache/iceberg/pull/7487#discussion_r1183969435
##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -873,4 +904,20 @@ private static Cache<String, AuthSession>
newSessionCache(Map<String, String> pr
(RemovalListener<String, AuthSession>) (id, auth, cause) ->
auth.stopRefreshing())
.build();
}
+
+ private Cache<TableOperations, FileIO> newFileIOCloser() {
+ return Caffeine.newBuilder()
+ .scheduler(
Review Comment:
From the docs for `removalListener`:
> For a more prompt notification on expiration a scheduler(Scheduler) may be
configured.
Do we need a scheduler? Isn't it fine if this happens when a new entry is
added?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
