szehon-ho commented on code in PR #7501:
URL: https://github.com/apache/iceberg/pull/7501#discussion_r1184004938
##########
api/src/main/java/org/apache/iceberg/RewriteFiles.java:
##########
@@ -34,13 +34,72 @@
* will throw a {@link ValidationException}.
*/
public interface RewriteFiles extends SnapshotUpdate<RewriteFiles> {
+ /**
+ * Delete a data file whose content was rewritten.
+ *
+ * @param dataFile a rewritten data file
+ * @return this for method chaining
+ */
+ default RewriteFiles deleteFile(DataFile dataFile) {
+ throw new UnsupportedOperationException(
+ this.getClass().getName() + " does not implement deleteFile");
+ }
+
+ /**
+ * Delete a delete file whose content was rewritten.
Review Comment:
Yea the way I read it, it may indicate that all the content will be
rewritten. But its likely in my case that it is just dropped without being
rewritten. Not sure if its just worth calling out here 'whose content was
rewritten'? Maybe we can do the other way around, and add the javadoc on
addFile(): 'Add a DeleteFile rewriting content of a deleted DeleteFile'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
