jackye1995 commented on code in PR #7505:
URL: https://github.com/apache/iceberg/pull/7505#discussion_r1184190019
##########
aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java:
##########
@@ -68,47 +68,63 @@ public class AwsProperties implements Serializable {
* AwsProperties#S3FILEIO_SSE_TYPE_NONE}.
*
* <p>For more details:
https://docs.aws.amazon.com/AmazonS3/latest/dev/serv-side-encryption.html
+ *
+ * @deprecated use {@link org.apache.iceberg.aws.s3.S3FileIOProperties}
instead
Review Comment:
nit: should also add "will be removed in Iceberg x.x". But I am not sure
what's the best version to remove it tbh. @amogh-jahagirdar @nastra any
thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
