akshayakp97 commented on code in PR #7505:
URL: https://github.com/apache/iceberg/pull/7505#discussion_r1184210542
##########
aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java:
##########
@@ -985,35 +933,35 @@ public String clientAssumeRoleSessionName() {
}
public String s3FileIoSseType() {
- return s3FileIoSseType;
+ return s3FileIOProperties.s3FileIoSseType();
Review Comment:
> Overall my thought is that we should not have nested properties
So, we don’t want to make any changes to the methods is it? If so, then I
have to add back the class fields to AwsProperties.
Which one do we want?
```
public String s3FileIoSseType() {
return s3FileIoSseType;
}
```
OR
```
public String s3FileIoSseType() {
return s3FileIOProperties.s3FileIoSseType();
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
