szehon-ho commented on PR #7469: URL: https://github.com/apache/iceberg/pull/7469#issuecomment-1535399213
OK, taking a look through it, I think it is not breaking Iceberg's [NessieCatalog](https://github.com/apache/iceberg/blob/master/nessie/src/main/java/org/apache/iceberg/nessie/NessieCatalog.java) but just any user of SparkCatalog that depended on case sensitive cache to be true. Seems to be the same the concern I mentioned at https://github.com/apache/iceberg/pull/7469#discussion_r1181945451 , consensus there was indeed that it should follow spark.sql.caseSensitive config. > spark.sql.caseSensitive, because AFAIU that property is used for the table schema (case (in)sensitive column names). I do see spark.sql.caseSensitive being used for table identifiers in some point in past like : https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala#L154 , but I guess now it may depend on backing Catalog. Hive Metastore for example is case insensitive period. I dont mind reverting default explicitly to the original value (true), though of course it means the other way, users who want case insensitive need to set it to false. Not sure what @wypoon @RussellSpitzer think, or if there is any other way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
