nastra commented on code in PR #7536:
URL: https://github.com/apache/iceberg/pull/7536#discussion_r1185747446
##########
core/src/main/java/org/apache/iceberg/io/ResolvingFileIO.java:
##########
@@ -83,21 +90,22 @@ public Map<String, String> properties() {
@Override
public void initialize(Map<String, String> newProperties) {
- close(); // close and discard any existing FileIO instances
Review Comment:
@rdblue do you remember why this was necessary? I added a flag for detecting
whether `close()` was already called to be used in the `finalize()` method.
Given that `close()` is being called here and then later again during a proper
`close()` call, I ended up removing this call here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
