nastra commented on code in PR #7536:
URL: https://github.com/apache/iceberg/pull/7536#discussion_r1187082295
##########
core/src/main/java/org/apache/iceberg/io/ResolvingFileIO.java:
##########
@@ -186,4 +194,19 @@ private static String scheme(String location) {
return null;
}
+
+ @SuppressWarnings("checkstyle:NoFinalizer")
+ @Override
+ protected void finalize() throws Throwable {
Review Comment:
@snazy I agree that `finalize()` is a pattern we shouldn't rely on, but on
Spark executor notes we don't have any other way of closing resources
unfortunately
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
