rdblue commented on code in PR #6884:
URL: https://github.com/apache/iceberg/pull/6884#discussion_r1186919115
##########
core/src/main/java/org/apache/iceberg/encryption/PlaintextEncryptionManager.java:
##########
@@ -25,6 +25,8 @@
import org.slf4j.LoggerFactory;
public class PlaintextEncryptionManager implements EncryptionManager {
+ public static final EncryptionManager INSTANCE = new
PlaintextEncryptionManager();
Review Comment:
I think we typically hide these behind static `instance` methods, rather
than making the instance field public.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
