wmoustafa commented on code in PR #6004:
URL: https://github.com/apache/iceberg/pull/6004#discussion_r1194167594
##########
core/src/test/java/org/apache/iceberg/avro/TestAvroNameMapping.java:
##########
@@ -205,7 +205,7 @@ public void testMissingRequiredFields() {
AssertHelpers.assertThrows(
"Missing required field in nameMapping",
IllegalArgumentException.class,
- "Missing required field: x",
+ "Missing required field that doesn't have a default value: x",
Review Comment:
I am saying `Missing required field with no default` could give the
impression that the fix is by adding a default value (also depending on how one
could read it, it could mean the fix is by introducing both the field and the
default value); however, in fact the fix is either by adding the field or
adding a default value. Hence, if we leave it at `Missing required field`, it
could be adequate. We could also say `Missing required field, or missing
default value`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
