wmoustafa commented on code in PR #6004:
URL: https://github.com/apache/iceberg/pull/6004#discussion_r1194622140
##########
.palantir/revapi.yml:
##########
@@ -16,9 +20,15 @@ acceptedBreaks:
- code: "java.method.addedToInterface"
new: "method java.util.List<org.apache.iceberg.StatisticsFile>
org.apache.iceberg.Table::statisticsFiles()"
justification: "new API method"
+ - code: "java.method.addedToInterface"
+ new: "method org.apache.iceberg.TableScan
org.apache.iceberg.TableScan::useRef(java.lang.String)"
+ justification: "Adding table scan APIs to support scanning from refs"
- code: "java.method.removed"
old: "method java.lang.Iterable<org.apache.iceberg.DataFile>
org.apache.iceberg.Snapshot::addedFiles()"
justification: "Deprecations for 1.0 release"
+ - code: "java.method.removed"
+ old: "method java.lang.Iterable<org.apache.iceberg.DataFile>
org.apache.iceberg.Snapshot::deletedFiles()"
+ justification: "Deprecations for 1.0 release"
Review Comment:
Right now this only contains
```
- code: "java.class.defaultSerializationChanged"
old: "class org.apache.iceberg.types.Types.NestedField"
new: "class org.apache.iceberg.types.Types.NestedField"
justification: "Serialization across versions is not supported"
```
I think this should be expected as we added a new API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
