dimas-b commented on code in PR #7642:
URL: https://github.com/apache/iceberg/pull/7642#discussion_r1198966399
##########
hive-runtime/build.gradle:
##########
@@ -43,6 +43,9 @@ project(':iceberg-hive-runtime') {
}
implementation(project(':iceberg-nessie')) {
exclude group: 'com.google.code.findbugs', module: 'jsr305'
+ // Nessie brings Jackson dependencies of version 2.15.0 or later.
+ // These are multi-release jars and doesn't work with Java-8 shadowJar
plugin.
+ exclude group: 'com.fasterxml.jackson', module: 'jackson-bom'
Review Comment:
No, I mean whether we can (and I'm not sure it's possible) to adjust Nessie
dependency declarations such that Iceberg prefers its own version of Jackson,
without repo-wide exclusions. I imagine similar changes may be required in all
other downstream projects that build with java 8.
##########
hive-runtime/build.gradle:
##########
@@ -43,6 +43,9 @@ project(':iceberg-hive-runtime') {
}
implementation(project(':iceberg-nessie')) {
exclude group: 'com.google.code.findbugs', module: 'jsr305'
+ // Nessie brings Jackson dependencies of version 2.15.0 or later.
+ // These are multi-release jars and doesn't work with Java-8 shadowJar
plugin.
+ exclude group: 'com.fasterxml.jackson', module: 'jackson-bom'
Review Comment:
No, I mean whether we can (and I'm not sure it's possible) adjust Nessie
dependency declarations such that Iceberg prefers its own version of Jackson,
without repo-wide exclusions. I imagine similar changes may be required in all
other downstream projects that build with java 8.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
