ajantha-bhat commented on code in PR #7642:
URL: https://github.com/apache/iceberg/pull/7642#discussion_r1198990104
##########
hive-runtime/build.gradle:
##########
@@ -43,6 +43,9 @@ project(':iceberg-hive-runtime') {
}
implementation(project(':iceberg-nessie')) {
exclude group: 'com.google.code.findbugs', module: 'jsr305'
+ // Nessie brings Jackson dependencies of version 2.15.0 or later.
+ // These are multi-release jars and doesn't work with Java-8 shadowJar
plugin.
+ exclude group: 'com.fasterxml.jackson', module: 'jackson-bom'
Review Comment:
The dependencies look like this before the exclude. So, Unless I exclude the
`jackson-bom`, the issue still exists for me.
```
+--- project :iceberg-nessie
| +--- project :iceberg-api (*)
| +--- project :iceberg-common (*)
| +--- project :iceberg-core (*)
| +--- project :iceberg-bundled-guava
| +--- org.projectnessie.nessie:nessie-client -> 0.59.0
| | +--- com.fasterxml.jackson:jackson-bom:2.15.1 (*)
| | +--- com.fasterxml.jackson.core:jackson-core -> 2.15.1 (*)
| | +--- com.fasterxml.jackson.core:jackson-databind -> 2.15.1 (*)
| | +--- com.fasterxml.jackson.core:jackson-annotations -> 2.15.1 (*)
| | +--- org.eclipse.microprofile.openapi:microprofile-openapi-api:3.1
| | \--- org.projectnessie.nessie:nessie-model:0.59.0
| | +--- com.fasterxml.jackson:jackson-bom:2.15.1 (*)
| | +--- com.fasterxml.jackson.core:jackson-databind -> 2.15.1 (*)
| | \--- com.fasterxml.jackson.core:jackson-annotations -> 2.15.1
(*)
| +--- com.fasterxml.jackson.core:jackson-databind -> 2.15.1 (*)
| \--- com.fasterxml.jackson.core:jackson-core -> 2.15.1 (*)
```
After excluding the `jackson-bom,` dependencies look like this.
```
+--- project :iceberg-nessie
| +--- project :iceberg-api (*)
| +--- project :iceberg-common (*)
| +--- project :iceberg-core (*)
| +--- project :iceberg-bundled-guava
| +--- org.projectnessie.nessie:nessie-client -> 0.59.0
| | +--- com.fasterxml.jackson.core:jackson-core -> 2.14.1 (*)
| | +--- com.fasterxml.jackson.core:jackson-databind -> 2.14.1 (*)
| | +--- com.fasterxml.jackson.core:jackson-annotations -> 2.14.1 (*)
| | +--- org.eclipse.microprofile.openapi:microprofile-openapi-api:3.1
| | \--- org.projectnessie.nessie:nessie-model:0.59.0
| | +--- com.fasterxml.jackson.core:jackson-databind -> 2.14.1 (*)
| | \--- com.fasterxml.jackson.core:jackson-annotations -> 2.14.1
(*)
| +--- com.fasterxml.jackson.core:jackson-databind -> 2.14.1 (*)
| \--- com.fasterxml.jackson.core:jackson-core -> 2.14.1 (*)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
