ajantha-bhat commented on code in PR #6712:
URL: https://github.com/apache/iceberg/pull/6712#discussion_r1199012120
##########
nessie/src/main/java/org/apache/iceberg/nessie/NessieCatalog.java:
##########
@@ -88,11 +89,24 @@ public void initialize(String name, Map<String, String>
options) {
options.get(removePrefix.apply(NessieConfigConstants.CONF_NESSIE_REF));
String requestedHash =
options.get(removePrefix.apply(NessieConfigConstants.CONF_NESSIE_REF_HASH));
- NessieApiV1 api =
+
+ NessieClientBuilder<?> nessieClientBuilder =
createNessieClientBuilder(
options.get(NessieConfigConstants.CONF_NESSIE_CLIENT_BUILDER_IMPL))
- .fromConfig(x -> options.get(removePrefix.apply(x)))
- .build(NessieApiV1.class);
+ .fromConfig(x -> options.get(removePrefix.apply(x)));
+ final String apiVersion = options.get(NessieUtil.CLIENT_API_VERSION);
+ NessieApiV1 api;
+ if (apiVersion == null || apiVersion.equalsIgnoreCase("v2")) {
+ // default version is set to v2.
+ api = nessieClientBuilder.build(NessieApiV2.class);
Review Comment:
I assumed the newer Nessie servers will have to V2 URI by default. I will
change it to V1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
