ajantha-bhat commented on code in PR #6712:
URL: https://github.com/apache/iceberg/pull/6712#discussion_r1229834658


##########
nessie/src/test/java/org/apache/iceberg/nessie/BaseTestIceberg.java:
##########
@@ -145,7 +147,8 @@ NessieCatalog initCatalog(String ref, String hash) {
             .put("ref", ref)
             .put(CatalogProperties.URI, uri)
             .put("auth-type", "NONE")
-            .put(CatalogProperties.WAREHOUSE_LOCATION, 
temp.toUri().toString());
+            .put(CatalogProperties.WAREHOUSE_LOCATION, temp.toUri().toString())
+            .put("client-api-version", apiVersion);

Review Comment:
   Nope. The other configurations like `uri`, `ref` is not using properties 
from `NessieConfigConstant` because catalog properties are passed without 
prefix. 
   
   `CONF_NESSIE_CLIENT_BUILDER_IMPL` is an exception which does not follow this 
style. We discussed this in Nessie public zulip channel and planning to 
deprecate it in future. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to