amogh-jahagirdar commented on code in PR #7665:
URL: https://github.com/apache/iceberg/pull/7665#discussion_r1199548962
##########
parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java:
##########
@@ -246,14 +245,15 @@ public <D> FileAppender<D> build() throws IOException {
int rowGroupSize = context.rowGroupSize();
int pageSize = context.pageSize();
int pageRowLimit = context.pageRowLimit();
- boolean dictionaryEnabled = context.dictionaryEnabled();
Review Comment:
Agreed, I think it makes sense, it also just follows the existing pattern a
lot better and is thus more readable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
