amogh-jahagirdar commented on code in PR #7665:
URL: https://github.com/apache/iceberg/pull/7665#discussion_r1199549050
##########
parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java:
##########
@@ -246,14 +245,15 @@ public <D> FileAppender<D> build() throws IOException {
int rowGroupSize = context.rowGroupSize();
int pageSize = context.pageSize();
int pageRowLimit = context.pageRowLimit();
- boolean dictionaryEnabled = context.dictionaryEnabled();
int dictionaryPageSize = context.dictionaryPageSize();
String compressionLevel = context.compressionLevel();
CompressionCodecName codec = context.codec();
int rowGroupCheckMinRecordCount = context.rowGroupCheckMinRecordCount();
int rowGroupCheckMaxRecordCount = context.rowGroupCheckMaxRecordCount();
int bloomFilterMaxBytes = context.bloomFilterMaxBytes();
Map<String, String> columnBloomFilterEnabled =
context.columnBloomFilterEnabled();
+ boolean enableDictionary =
+
Boolean.valueOf(config.getOrDefault(ParquetOutputFormat.ENABLE_DICTIONARY,
"true"));
Review Comment:
Updated, unfortunately still goes to a newline but it's cleaner!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
