nastra commented on code in PR #7569:
URL: https://github.com/apache/iceberg/pull/7569#discussion_r1200810460
##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -916,4 +920,31 @@ private Cache<TableOperations, FileIO> newFileIOCloser() {
})
.build();
}
+
+ @Override
+ public void commitTransaction(SessionContext context, List<TableCommit>
commits) {
+ ImmutableCommitTransactionRequest.Builder builder =
ImmutableCommitTransactionRequest.builder();
+
+ for (TableCommit commit : commits) {
+ UpdateTableRequest.Builder updateTableBuilder =
UpdateTableRequest.builderFor(commit.base());
+ commit.changes().forEach(updateTableBuilder::update);
+ UpdateTableRequest updateTableRequest = updateTableBuilder.build();
Review Comment:
yes I agree, we'd have to pull them out of the REST layer and make them work
for non-REST catalogs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
