nastra commented on code in PR #7569:
URL: https://github.com/apache/iceberg/pull/7569#discussion_r1200842849
##########
core/src/main/java/org/apache/iceberg/catalog/BaseSessionCatalog.java:
##########
@@ -62,6 +62,11 @@ public <T> T withContext(SessionContext context,
Function<Catalog, T> task) {
return task.apply(asCatalog(context));
}
+ public void commitTransaction(SessionContext context, List<TableCommit>
commits) {
Review Comment:
generally speaking, the plan was to add this to `SessionCatalog` and
`Catalog` (which are both in the `api` module), but given that we currently
have `TableMetadata` (which is in the `core` module) in `TableCommit`, this
turned out to be difficult.
I've changed this up now so that it's only defined in `RESTSessionCatalog`
and `RESTCatalog`. I think putting this method there is probably best for now
and later we can move them to interfaces.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
