szehon-ho commented on code in PR #7713:
URL: https://github.com/apache/iceberg/pull/7713#discussion_r1207194184
##########
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/source/SparkScanBuilder.java:
##########
@@ -171,7 +171,10 @@ public Filter[] pushFilters(Filter[] filters) {
}
} catch (Exception e) {
- LOG.warn("Failed to check if {} can be pushed down: {}", filter,
e.getMessage());
Review Comment:
Yea let me check this, i thought initially in those cases that we fail to
bind, and get an exception.
Hence thought we should not log the stack, as that is a "normal" case.
I think we had decided it was a bit polluting , in some discussion here:
https://github.com/apache/iceberg/pull/5254#issuecomment-1183804207 , but if
it only for abnormal case , I agree we should have a stack.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
