aokolnychyi commented on code in PR #7713:
URL: https://github.com/apache/iceberg/pull/7713#discussion_r1207294674
##########
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/source/SparkScanBuilder.java:
##########
@@ -171,7 +171,10 @@ public Filter[] pushFilters(Filter[] filters) {
}
} catch (Exception e) {
- LOG.warn("Failed to check if {} can be pushed down: {}", filter,
e.getMessage());
Review Comment:
There is a check above to see if the converted filter is not null, that
tells us if the filter is supported or not. We could log it there.
I am 50/50 on logging the trace. Let me think a bit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
