rakesh-das08 commented on code in PR #7730:
URL: https://github.com/apache/iceberg/pull/7730#discussion_r1210443049
##########
api/src/test/java/org/apache/iceberg/expressions/TestNumericLiteralConversions.java:
##########
@@ -176,30 +174,36 @@ public void testDecimalToDecimalConversion() {
IntStream.range(0, 10)
.forEach(
scale -> {
- Assert.assertSame(
- "Should return identical object", lit,
lit.to(Types.DecimalType.of(9, scale)));
- Assert.assertSame(
- "Should return identical object", lit,
lit.to(Types.DecimalType.of(11, scale)));
+ assertThat(lit.to(Types.DecimalType.of(9, scale)))
+ .as("Should return identical object")
+ .isSameAs(lit);
+ assertThat(lit.to(Types.DecimalType.of(11, scale)))
+ .as("Should return identical object")
+ .isSameAs(lit);
});
}
@Test
public void testIntegerToDateConversion() {
Literal<Integer> lit = Literal.of(0);
- Assert.assertEquals(
- "Dates should be equal", lit.to(Types.DateType.get()), new
Literals.DateLiteral(0));
+ assertThat(new Literals.DateLiteral(0))
+ .as("Dates should be equal")
Review Comment:
Same as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
