rakesh-das08 commented on code in PR #7730:
URL: https://github.com/apache/iceberg/pull/7730#discussion_r1210444608
##########
api/src/test/java/org/apache/iceberg/expressions/TestEvaluator.java:
##########
@@ -552,72 +599,81 @@ public void testCaseSensitiveNot() {
public void testCharSeqValue() {
StructType struct = StructType.of(required(34, "s",
Types.StringType.get()));
Evaluator evaluator = new Evaluator(struct, equal("s", "abc"));
- Assert.assertTrue(
- "string(abc) == utf8(abc) => true",
evaluator.eval(TestHelpers.Row.of(new Utf8("abc"))));
- Assert.assertFalse(
- "string(abc) == utf8(abcd) => false",
evaluator.eval(TestHelpers.Row.of(new Utf8("abcd"))));
+ assertThat(evaluator.eval(TestHelpers.Row.of(new Utf8("abc"))))
+ .as("string(abc) == utf8(abc) => true")
+ .isTrue();
+ assertThat(evaluator.eval(TestHelpers.Row.of(new Utf8("abcd"))))
+ .as("string(abc) == utf8(abcd) => false")
+ .isFalse();
}
@Test
public void testIn() {
- Assert.assertEquals(3, in("s", 7, 8, 9).literals().size());
- Assert.assertEquals(3, in("s", 7, 8.1, Long.MAX_VALUE).literals().size());
- Assert.assertEquals(3, in("s", "abc", "abd", "abc").literals().size());
- Assert.assertEquals(0, in("s").literals().size());
- Assert.assertEquals(1, in("s", 5).literals().size());
- Assert.assertEquals(2, in("s", 5, 5).literals().size());
- Assert.assertEquals(2, in("s", Arrays.asList(5, 5)).literals().size());
- Assert.assertEquals(0, in("s", Collections.emptyList()).literals().size());
+ assertThat(in("s", 7, 8, 9).literals().size()).isEqualTo(3);
Review Comment:
Somehow missed this file for the suggested changes. Thank you. Have made the
changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
