nastra commented on code in PR #7730:
URL: https://github.com/apache/iceberg/pull/7730#discussion_r1215447617
##########
api/src/test/java/org/apache/iceberg/expressions/TestPredicateBinding.java:
##########
@@ -66,13 +66,12 @@ public void testMultipleFields() {
Expression expr = unbound.bind(struct);
BoundPredicate<Integer> bound = assertAndUnwrap(expr);
- Assert.assertEquals("Should reference correct field ID", 11,
bound.ref().fieldId());
- Assert.assertEquals("Should not change the comparison operation", LT,
bound.op());
- Assert.assertTrue("Should be a literal predicate",
bound.isLiteralPredicate());
- Assert.assertEquals(
- "Should not alter literal value",
- Integer.valueOf(6),
- bound.asLiteralPredicate().literal().value());
+ assertThat(bound.ref().fieldId()).as("Should reference correct field
ID").isEqualTo(11);
+ assertThat(bound.op()).as("Should not change the comparison
operation").isEqualTo(LT);
+ assertThat(bound.isLiteralPredicate()).isTrue();
+ assertThat(bound.asLiteralPredicate().literal().value())
+ .as("Should not alter literal value")
+ .isEqualTo(Integer.valueOf(6));
Review Comment:
```suggestion
.isEqualTo(6);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
