nastra commented on code in PR #7730:
URL: https://github.com/apache/iceberg/pull/7730#discussion_r1213960711
##########
api/src/test/java/org/apache/iceberg/expressions/TestPredicateBinding.java:
##########
@@ -134,7 +134,7 @@ public void testLiteralConversion() {
assertThat(bound.isLiteralPredicate()).isTrue();
assertThat(bound.asLiteralPredicate().literal().value())
.as("Should convert literal value to decimal")
- .isEqualTo(new BigDecimal("12.40"));
+ .isEqualTo("12.40");
Review Comment:
we can leave the BigDecimal stuff because
`bound.asLiteralPredicate().literal().value()` will produce a `BigDecimal` and
so we're expecting a `BigDecimal` here. The only reason this test passes is
actually because `isEqualTo()` will convert that String to a `BigDecimal` again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
