nastra commented on code in PR #7757:
URL: https://github.com/apache/iceberg/pull/7757#discussion_r1215449224
##########
api/src/test/java/org/apache/iceberg/io/TestCloseableIterable.java:
##########
@@ -107,9 +108,9 @@ public void testWithCompletionRunnable() throws IOException
{
try (CloseableIterable<Integer> iter =
CloseableIterable.whenComplete(
CloseableIterable.combine(items, () -> {}),
completionCounter::incrementAndGet)) {
- iter.forEach(val ->
Assertions.assertThat(completionCounter.get()).isEqualTo(0));
+ iter.forEach(val -> assertThat(completionCounter.get()).isZero());
}
- Assertions.assertThat(completionCounter.get()).isEqualTo(1);
+ assertThat(completionCounter.get()).isOne();
Review Comment:
is there any value in changing this from `isEqualTo()` to `isOne()`? IMO it
just adds additional review overhead for something that is already quite large
reviewing effort
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
