rakesh-das08 commented on code in PR #7757:
URL: https://github.com/apache/iceberg/pull/7757#discussion_r1215480332
##########
api/src/test/java/org/apache/iceberg/io/TestCloseableIterable.java:
##########
@@ -107,9 +108,9 @@ public void testWithCompletionRunnable() throws IOException
{
try (CloseableIterable<Integer> iter =
CloseableIterable.whenComplete(
CloseableIterable.combine(items, () -> {}),
completionCounter::incrementAndGet)) {
- iter.forEach(val ->
Assertions.assertThat(completionCounter.get()).isEqualTo(0));
+ iter.forEach(val -> assertThat(completionCounter.get()).isZero());
}
- Assertions.assertThat(completionCounter.get()).isEqualTo(1);
+ assertThat(completionCounter.get()).isOne();
Review Comment:
Thank you Eduard for taking time to review this. Would keep this in mind.
But one qq: Since you have already spent time in reviewing these changes
should i revert the isEqualTo() to isOne()/isZero() changes or keep them as it
is for now ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
