pvary commented on code in PR #7661:
URL: https://github.com/apache/iceberg/pull/7661#discussion_r1222886555
##########
flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/source/assigner/SimpleSplitAssignerFactory.java:
##########
@@ -23,14 +23,15 @@
/** Create simple assigner that hands out splits without any guarantee in
order or locality. */
public class SimpleSplitAssignerFactory implements SplitAssignerFactory {
+ public SimpleSplitAssignerFactory() {}
@Override
- public SimpleSplitAssigner createAssigner() {
- return new SimpleSplitAssigner();
+ public DefaultSplitAssigner createAssigner() {
Review Comment:
Not really an issue as the `DefaultSplitAssigner` extends `SplitAssigner`,
but changed the return type anyway
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
