pvary commented on code in PR #7661:
URL: https://github.com/apache/iceberg/pull/7661#discussion_r1226618791
##########
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/source/reader/TestIcebergSourceReader.java:
##########
@@ -55,13 +56,67 @@ public void testReaderMetrics() throws Exception {
TestingReaderOutput<RowData> readerOutput = new TestingReaderOutput<>();
TestingMetricGroup metricGroup = new TestingMetricGroup();
TestingReaderContext readerContext = new TestingReaderContext(new
Configuration(), metricGroup);
- IcebergSourceReader reader = createReader(metricGroup, readerContext);
+ IcebergSourceReader reader = createReader(metricGroup, readerContext,
null);
reader.start();
testOneSplitFetcher(reader, readerOutput, metricGroup, 1);
testOneSplitFetcher(reader, readerOutput, metricGroup, 2);
}
+ @Test
+ public void testReaderOrder() throws Exception {
+ // Create 2 splits
+ List<List<Record>> recordBatchList1 =
+ ReaderUtil.createRecordBatchList(0L, TestFixtures.SCHEMA, 1, 1);
+ CombinedScanTask task1 =
+ ReaderUtil.createCombinedScanTask(
+ recordBatchList1, TEMPORARY_FOLDER, FileFormat.PARQUET,
appenderFactory);
+
+ List<List<Record>> recordBatchList2 =
+ ReaderUtil.createRecordBatchList(1L, TestFixtures.SCHEMA, 1, 1);
+ CombinedScanTask task2 =
+ ReaderUtil.createCombinedScanTask(
+ recordBatchList2, TEMPORARY_FOLDER, FileFormat.PARQUET,
appenderFactory);
+
+ // Sort the splits in one way
+ List<RowData> rowData1 =
+ read(
+ Arrays.asList(
+ IcebergSourceSplit.fromCombinedScanTask(task1),
+ IcebergSourceSplit.fromCombinedScanTask(task2)),
+ 2);
+
+ // Reverse the splits
+ List<RowData> rowData2 =
+ read(
+ Arrays.asList(
+ IcebergSourceSplit.fromCombinedScanTask(task2),
+ IcebergSourceSplit.fromCombinedScanTask(task1)),
+ 2);
+
+ // Check that the order of the elements is not changed
+ Assert.assertEquals(rowData1.get(0), rowData2.get(0));
+ Assert.assertEquals(rowData1.get(1), rowData2.get(1));
+ }
+
+ private List<RowData> read(List<IcebergSourceSplit> splits, long expected)
throws Exception {
+ TestingMetricGroup metricGroup = new TestingMetricGroup();
+ TestingReaderContext readerContext = new TestingReaderContext(new
Configuration(), metricGroup);
+ IcebergSourceReader reader = createReader(metricGroup, readerContext, new
IdBasedComparator());
Review Comment:
When there is no comparator there is no specification defining the read
order, so I think adding a test for that is not needed.
Also we have many other tests where the comparator is set to `null`, so I
think we can rely on them if the goal is to check that the
`IcebergSourceReader` is working with `null` comparator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
