rdblue commented on code in PR #7750:
URL: https://github.com/apache/iceberg/pull/7750#discussion_r1227351962
##########
core/src/main/java/org/apache/iceberg/rest/RESTTableOperations.java:
##########
@@ -133,9 +143,7 @@ public void commit(TableMetadata base, TableMetadata
metadata) {
String.format("Update type %s is not supported", updateType));
}
- baseChanges.forEach(requestBuilder::update);
- metadata.changes().forEach(requestBuilder::update);
- UpdateTableRequest request = requestBuilder.build();
+ UpdateTableRequest request = new UpdateTableRequest(requirements, updates);
Review Comment:
The other request classes use a builder. I think that the intent here is to
use the public constructor because the builder changed substantially and can't
be updated to work for both. It would be nice to use the builder later, but I
can see why this needs to be public and used at the moment.
##########
core/src/main/java/org/apache/iceberg/rest/RESTTableOperations.java:
##########
@@ -133,9 +143,7 @@ public void commit(TableMetadata base, TableMetadata
metadata) {
String.format("Update type %s is not supported", updateType));
}
- baseChanges.forEach(requestBuilder::update);
- metadata.changes().forEach(requestBuilder::update);
- UpdateTableRequest request = requestBuilder.build();
+ UpdateTableRequest request = new UpdateTableRequest(requirements, updates);
Review Comment:
The other request classes use a builder. I think that the intent here is to
use the public constructor because the builder changed substantially and can't
be updated to work for both. It would be nice to use a builder later, but I can
see why this needs to be public and used at the moment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
