nastra commented on code in PR #7750:
URL: https://github.com/apache/iceberg/pull/7750#discussion_r1227657498
##########
core/src/main/java/org/apache/iceberg/rest/RESTTableOperations.java:
##########
@@ -133,9 +143,7 @@ public void commit(TableMetadata base, TableMetadata
metadata) {
String.format("Update type %s is not supported", updateType));
}
- baseChanges.forEach(requestBuilder::update);
- metadata.changes().forEach(requestBuilder::update);
- UpdateTableRequest request = requestBuilder.build();
+ UpdateTableRequest request = new UpdateTableRequest(requirements, updates);
Review Comment:
yes exactly, the builder changed substantially. In the long run I think we
can add a builder again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
