nastra commented on code in PR #6512:
URL: https://github.com/apache/iceberg/pull/6512#discussion_r1231898096
##########
core/src/main/java/org/apache/iceberg/rest/ResourcePaths.java:
##########
@@ -61,6 +61,11 @@ public String tables(Namespace ns) {
return SLASH.join("v1", prefix, "namespaces",
RESTUtil.encodeNamespace(ns), "tables");
}
+ public String register(Namespace ns) {
+ return SLASH.join(
+ "v1", prefix, "namespaces", RESTUtil.encodeNamespace(ns), "tables",
"register");
Review Comment:
we've had some internal discussion on what the pathing should look like and
`/v1/{prefix}/namespaces/{namespace}/register` makes probably the most sense
here.
Having `/v1/{prefix}/namespaces/{namespace}/tables/register` would conflict
when a table is called `register`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
