nastra commented on code in PR #6512:
URL: https://github.com/apache/iceberg/pull/6512#discussion_r1244994033
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -1913,6 +1965,17 @@ components:
additionalProperties:
type: string
+ RegisterTableRequest:
+ type: object
+ required:
+ - name
+ - metadata-location
+ properties:
+ identifier:
Review Comment:
```suggestion
name:
```
##########
core/src/test/java/org/apache/iceberg/rest/RESTCatalogAdapter.java:
##########
@@ -344,7 +350,13 @@ public <T extends RESTResponse> T handleRequest(
TableIdentifier ident = identFromPathVars(vars);
return castResponse(responseType, CatalogHandlers.loadTable(catalog,
ident));
}
-
+ case REGISTER_TABLE:
+ {
+ Namespace namespace = namespaceFromPathVars(vars);
+ RegisterTableRequest request =
castRequest(RegisterTableRequest.class, body);
+ return castResponse(
+ responseType, CatalogHandlers.registerTable(catalog, namespace,
request));
+ }
Review Comment:
nit: add an empty line after the closing } to align with all the code inside
this switch block
##########
core/src/test/java/org/apache/iceberg/rest/RESTCatalogAdapter.java:
##########
@@ -344,7 +350,13 @@ public <T extends RESTResponse> T handleRequest(
TableIdentifier ident = identFromPathVars(vars);
return castResponse(responseType, CatalogHandlers.loadTable(catalog,
ident));
}
-
Review Comment:
nit: we probably want to keep that empty line
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -1913,6 +1965,17 @@ components:
additionalProperties:
type: string
+ RegisterTableRequest:
+ type: object
+ required:
+ - name
+ - metadata-location
+ properties:
+ identifier:
Review Comment:
this should fix the CI failure. Also make sure to go through
https://github.com/apache/iceberg/blob/master/open-api/README.md#generate-python-code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
